fix(prover): Create reqwest client only once #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating reqwest client is expensive because it initializes TLS, loads certificates, etc. So it should be create only once and reused. Create new internal mod http_client instead of patching zksync_utils because fn `send_request_with_retries` is used only in prover_autoscaler and outdated prover_gpu_fri, which will be removed soon. Additionally HttpClient exports metric `calls` with all the requests and correct status codes. ref ZKD-1855
…quick-prover-autoscaler-http-client
EmilLuta
approved these changes
Nov 25, 2024
yorik
deleted the
ya--implement-poc-of-quick-prover-autoscaler-http-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Create reqwest client only once.
Additionally HttpClient exports metric
callswith all the requests and correct status codes.Why ❔
Creating reqwest client is expensive because it initializes TLS, loads certificates, etc. So it should be create only once and reused.
Create new internal mod http_client instead of patching zksync_utils because fn
send_request_with_retriesis used only in prover_autoscaler and outdated prover_fri, which will be removed soon.Checklist
zkstack dev fmtandzkstack dev lint.ref ZKD-1855