Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add interop docs to mdbook #3327

Merged
merged 5 commits into from
Nov 25, 2024
Merged

docs: add interop docs to mdbook #3327

merged 5 commits into from
Nov 25, 2024

Conversation

kaymomin
Copy link
Contributor

No description provided.

popzxc
popzxc previously approved these changes Nov 25, 2024
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest to get an approval from Kalman or Stas to make sure that the contents are up-to-date.

@popzxc
Copy link
Member

popzxc commented Nov 25, 2024

Ah, @kaymomin I see that lints are failing. I guess you need to run zkstack dev fmt to fix CI.

@kaymomin
Copy link
Contributor Author

Ah, @kaymomin I see that lints are failing. I guess you need to run zkstack dev fmt to fix CI.

on it!!

kelemeno
kelemeno previously approved these changes Nov 25, 2024
@kaymomin kaymomin dismissed stale reviews from kelemeno and popzxc via 98de704 November 25, 2024 11:41
popzxc
popzxc previously approved these changes Nov 25, 2024
@popzxc popzxc added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit f4b772a Nov 25, 2024
19 of 20 checks passed
@popzxc popzxc deleted the interop-docs branch November 25, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants