Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offcycle: Release circuit provers for v24.2 #3328

Closed
wants to merge 1 commit into from

Conversation

EmilLuta
Copy link
Contributor

@EmilLuta EmilLuta commented Nov 25, 2024

This is an impromptu PR to release a fork from v17.0.0, adjusted for protocol version v24.2. Whilst this exercise exposes multiple risks, it is done internally to derisk moving from v24.2 to v25 on mainnet.

This release is not mandatory and is done mostly to carry circuit provers to mainnet, without being blocked by protocol upgrade. The same changes will arrive to mainnet later on during the v25 protocol upgrade.

This is an impromptu PR to release a fork from v17.0.0, adjusted for
v24.2. Whilst this exercise exposes multiple risks, it is done
internally to derisk moving from v24.2 to v25.

This release is unnecessary and is done mostly to carry circuit provers
to mainnet, without being blocked by protocol upgrade.
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

Unknown release type "offcycle" found in pull request title "offcycle: Release circuit provers for v24.2". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@EmilLuta
Copy link
Contributor Author

This PR is just a demonstration of the changes that will be released with provers-v16.7.0. Closing as it will never be merged.

@EmilLuta EmilLuta closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant