Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): [DO NOT MERGE] Custom branch for v25 genesis #3350

Closed
wants to merge 23 commits into from

Conversation

sanekmelnikov
Copy link
Collaborator

@sanekmelnikov sanekmelnikov commented Dec 1, 2024

What ❔

This is custom branch for matterlabs/server-v2:v25.1.0.genesis Docker image.

Changes:

  • update the values in genesis.yaml, sepolia.yaml, mainnet.yaml to match v25
  • make zkstack_cli compile system contracts with hardhat instead of forge

Why ❔

The v25 protocol upgrade was performed using system contracts compiled with Hardhat.
However, since both zkstack and genesis logic use Forge by default, running the process from the main branch results in system contracts being deployed with differing bytecodes. This discrepancy leads to mismatched genesis hashes and failure during the genesis step for the new chains.
As a result, it is currently impossible to perform the genesis of new v25 chains on the ZKsync ecosystems (e.g., Sepolia, Mainnet) directly from the main branch. This branch has been created specifically to perform the genesis step for these environments.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@sanekmelnikov sanekmelnikov changed the title Custom branch for v25 genesis fix(configs): Custom branch for v25 genesis Dec 1, 2024
@sanekmelnikov sanekmelnikov marked this pull request as ready for review December 2, 2024 17:11
@sanekmelnikov sanekmelnikov requested a review from a team as a code owner December 2, 2024 17:11
@sanekmelnikov sanekmelnikov changed the title fix(configs): Custom branch for v25 genesis fix(configs): [DO NOT MERGE] Custom branch for v25 genesis Dec 2, 2024
@sanekmelnikov sanekmelnikov marked this pull request as draft December 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants