Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracer): adds vm error to flatCallTracer error field if exists #3374

Merged
merged 3 commits into from
Dec 11, 2024
+11 −5
Merged

fix(tracer): adds vm error to flatCallTracer error field if exists #3374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95fadf1
fix(tracer): adds vm error to error field if exists
dutterbutter Dec 10, 2024
1bcf88f
Merge branch 'main' into db/add-vm-errors-to-flat-tracer
dutterbutter Dec 11, 2024
0f2feba
Merge branch 'main' into db/add-vm-errors-to-flat-tracer
dutterbutter Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions core/node/api_server/src/web3/namespaces/debug.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,22 @@ impl DebugNamespace {
CallType::NearCall => unreachable!("We have to filter our near calls before"),
};

let (result, error) = if let Some(error) = call.revert_reason {
(None, Some(error))
} else {
(
let (result, error) = match (call.revert_reason, call.error) {
(Some(revert_reason), _) => {
// If revert_reason exists, it takes priority over VM error
(None, Some(revert_reason))
}
(None, Some(vm_error)) => {
// If no revert_reason but VM error exists
(None, Some(vm_error))
}
(None, None) => (
Some(CallResult {
output: web3::Bytes::from(call.output),
gas_used: U256::from(call.gas_used),
}),
None,
)
),
};

calls.push(DebugCallFlat {
Expand Down
Loading