Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt server for new EVM bytecode hash encoding #3396

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

0xVolosnikov
Copy link
Contributor

What ❔

After latest EVM emulator contract changes, EVM bytecode doesn't include any king of prefix with bytecode length. Actual unpadded raw EVM bytecode length is encoded directly in versioned bytecode hash.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@0xVolosnikov 0xVolosnikov requested a review from slowli December 18, 2024 11:52
@0xVolosnikov 0xVolosnikov marked this pull request as draft December 18, 2024 12:04
@0xVolosnikov 0xVolosnikov marked this pull request as ready for review December 18, 2024 14:48
core/node/api_server/src/web3/namespaces/eth.rs Outdated Show resolved Hide resolved
slowli
slowli previously approved these changes Dec 19, 2024
@0xVolosnikov 0xVolosnikov requested a review from slowli December 19, 2024 14:12
@0xVolosnikov 0xVolosnikov added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@0xVolosnikov 0xVolosnikov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 5a1e6d2 Dec 19, 2024
32 checks passed
@0xVolosnikov 0xVolosnikov deleted the vv-change-evm-bytecode-hashes-encoding branch December 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants