Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update EVM emulator feature in zkstack and zk #3397

Merged
merged 18 commits into from
Dec 19, 2024
Merged

feat: Update EVM emulator feature in zkstack and zk #3397

merged 18 commits into from
Dec 19, 2024

Conversation

0xVolosnikov
Copy link
Contributor

@0xVolosnikov 0xVolosnikov commented Dec 18, 2024 •
edited
Loading

What ❔

Following the latest changes to the EVM emulator contracts, the process for enabling the EVM emulator has changed.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@0xVolosnikov 0xVolosnikov marked this pull request as ready for review December 18, 2024 13:55
slowli
slowli reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, zk is no longer maintained. I guess it wouldn't harm to include new functionality into it, but I wouldn't spend much effort on it.

zkstack_cli/crates/zkstack/src/enable_evm_emulator.rs Outdated Show resolved Hide resolved
zkstack_cli/crates/config/src/forge_interface/enable_evm_emulator/mod.rs Outdated Show resolved Hide resolved
@0xVolosnikov 0xVolosnikov requested a review from slowli December 19, 2024 14:24
slowli
slowli previously approved these changes Dec 19, 2024
View reviewed changes
@0xVolosnikov 0xVolosnikov requested a review from slowli December 19, 2024 15:55
@0xVolosnikov 0xVolosnikov added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@0xVolosnikov 0xVolosnikov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e4848c5 Dec 19, 2024
42 checks passed
@0xVolosnikov 0xVolosnikov deleted the vv-update-evm-emulator-feature-in-zkstack-and-zk branch December 19, 2024 23:34
@zksync-era-bot zksync-era-bot mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli approved these changes

@sanekmelnikov sanekmelnikov Awaiting requested review from sanekmelnikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xVolosnikov @slowli