Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: incorrect link reference in 03_withdrawals.md #342

Closed
wants to merge 5 commits into from
Closed

docs: incorrect link reference in 03_withdrawals.md #342

wants to merge 5 commits into from

Conversation

Saladerl
Copy link
Contributor

What ❔

  • Change link for Contract docs in 03_withdrawals.md.

Why ❔

  • The previous link is 404'ing

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Saladerl
docs: incorrect link reference in 03_withdrawals.md
cca32b9 
docs: incorrect link reference in 03_withdrawals.md
@Saladerl Saladerl requested a review from a team as a code owner October 27, 2023 20:15
popzxc
popzxc reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the contribution.
Looks like there are other links to the system-contracts repo in this file, could you maybe fix them as well, given that you already started working on this file?

@Saladerl
Copy link
Contributor Author

Hello! Thanks for the contribution. Looks like there are other links to the system-contracts repo in this file, could you maybe fix them as well, given that you already started working on this file?

completed

popzxc
popzxc previously approved these changes Oct 30, 2023
View reviewed changes
@popzxc popzxc enabled auto-merge October 30, 2023 09:27
auto-merge was automatically disabled October 30, 2023 11:39

Head branch was pushed to by a user without write access

@Saladerl Saladerl closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc left review comments

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saladerl @popzxc