New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enhance witness generator tests with parameterization and parallel execution #3586

Closed

avorylli wants to merge 1 commit into matter-labs:main from avorylli:fix

avorylli commented Feb 9, 2025

This PR improves the witness generator test suite by:

Added parameterized tests for different circuit IDs
Added parallel execution test to verify concurrent witness generation
Improved error handling tests with invalid circuit IDs and empty prover job IDs
Added execution time checks for performance monitoring
Enhanced error messages for better debugging

Technical changes:

Extracted test data paths to constants
Added helper functions for test object store creation
Added comprehensive test documentation


          Update basic_test.rs

16de14b

github-actions bot added the external-contribution label

Contributor

EmilLuta commented Mar 3, 2025

Thank you for the effort, but we don't really accept AI-generated contributions; the tests changed are currently being ignored.

EmilLuta closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution