refactor(eth_client): Use BlockId
for block_id
instead of String in eth_client
#499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
The
block
function withineth_client
now uses the typeBlockId
instead ofString
for itsblock_id
parameter.Why ❔
TODO comment:
zksync-era/core/lib/eth_client/src/clients/http/query.rs
Lines 289 to 308 in cb873bd
This PR fixes the TODO.
The
web3
crate being used inside the project was updated to version0.19.0
insidecore/lib/basic_types/Cargo.toml
in commit 829ef50.The
web3
crate now supportsBlockNumber::Finalized
.Source: https://docs.rs/web3/latest/web3/types/enum.BlockNumber.html
Source: https://github.com/tomusdrw/rust-web3/releases/tag/v0.19.0
Checklist
zk fmt
andzk lint
.