-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation Images to Latest Interface and Formats #7548
Conversation
Deleted a set of images from the `source/images/` directory that are no longer referenced in the Mattermost documentation. This cleanup helps reduce clutter and maintain a streamlined set of assets for future documentation updates.
Hello @yesbhautik, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Newest code from yesbhautik has been published to preview environment for Git SHA 513ceab |
@yesbhautik - This is an outstanding docs PR with high impact! Thank you so much. How easy would it be for you to do the following without a lot of rework?
If it's easy, could you make these changes to all impacted screenshots, please? If it means entirely re-capturing the images, let's not introduce more work than you've already done. Also, please ensure all mobile screenshots are scaled down to 30%. They're currently quite large on a given docs page. |
I added hand pointers while taking screenshots because I thought they would provide better clarification for users. Regarding the red outlines, I only included them where they were previously present in the documentation. As per your request, I can address the issue of hand pointers and remove them from the screenshots. However, in the case of red outlines, most of the screenshots where these outlines are present are outside the Mattermost platform, such as in Azure portal, Windows, and other external interfaces. Removing the red outlines from these could be quite challenging and may introduce errors or inconsistencies. To effectively remove the red outlines, I can utilize premium software and AI tools to streamline the process. Please provide further confirmation so I can proceed with these adjustments. |
The mobile screenshots appear quite large because we used the original, high-resolution images. Scaling them down in the future could complicate updates. We have two possible solutions to address this:
Please confirm which option you prefer to proceed with. If opting for the CSS solution, we can initiate a new issue to track and implement the changes. |
@yesbhautik - Given the effort it will take to remove elements from the new product screenshots (advanced tooling and AI), I would prefer not to ask you to complete that extra work, given how much you've already contributed in this docs PR. I do want to provide context as to why I explored the effort to remove the elements:
Again, given the effort needed to remove these elements, I am open to accepting this PR as-is. However, note that there are merge conflicts that need to be resolved first. Any merge conflicts you're seeing are because another contributor is currently creating brand new mobile-specific screenshots (where the image files are prepended with Regarding scaling mobile screenshots: Please add the |
Alright, no worries. Marge this PR after clearance if conflicts & image reducing the mobile screenshot scale. Just create |
I tried to find previous |
Hello, @cwarnermm. The issue with the mobile screenshot size scaling has been resolved. Regarding the conflicts, I am getting some error in Web editor. Please find the attached screenshot. Could you resolve this minor conflict issue? |
@yesbhautik - I may be mis-remembering that there were additional merge conflict resolutions that need to be revisited on this PR. If this is the first time you're encountering merge conflicts, then I can confirm that I'm mixing up this PR with others :) For the current merge conflicts, I need you to revert any screenshot you've modified that starts with |
Come on, I have worked with merge conflicts, but I am getting confused here. Also, I was unable to find conflicts details & reason. No worries. Still tired. |
@yesbhautik - Please revert/remove the following image updates from this PR:
And any other image update you've made whose filename starts with Also - I didn't intend to suggest that you weren't familiar with merge conflict workflows. I was intending to say that if you and I haven't talked about merge conflicts until now in the context of this PR, that's entirely a mistake I've made by mixing up this PR with another PR. |
This reverts commit 9939a01.
@cwarnermm I have replaced my images with old images as it was. |
Newest code from yesbhautik has been published to preview environment for Git SHA a9619bb |
Updated all images to the latest Mattermost interface within the
source/images
directory. This update includes replacing outdated screenshots and, where necessary, changing image formats from PNG to GIF to enhance clarity and understanding in the documentation.Summary
This pull request comprehensively updates the documentation images to reflect the latest Mattermost interface. The updates ensure that all screenshots are current and align with standard expectations. Additionally, some images were converted from PNG to GIF to provide better visual guidance where animations or multi-step processes were illustrated.
Ticket Link
Ticket Link
Milestone 02, 03, 04: #6658