-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate point and fix date format #1410
Remove duplicate point and fix date format #1410
Conversation
The current date format wasn't parsable leading to an error when running 'make run'. I kept the second bullet point because it's the most recent one.
Hello @Victor-Nyagudi, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
The docs recommend using 'newtabref' for links navigating away from developers.mattermost.com
cc: @cwarnermm Discussed the change first in the Mattermost Content channel. |
Newest code from Victor-Nyagudi has been published to preview environment for Git SHA 56a0e79 |
The current date format wasn't parsable leading to an error when running 'make run'. I kept the second bullet point because it's the most recent one.
The docs recommend using 'newtabref' for links navigating away from developers.mattermost.com
…agudi/mattermost-developer-documentation into remove-duplicate-point
Thought I'd fix that sentence in this PR as well. Discussed it first in this channel. Didn't know I used Is a "squash and merge" a viable option here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Victor-Nyagudi!
Summary
Removed a duplicate bullet point on the "Why and how to contribute" page.
I kept the second bullet point because it's the most recent one added in this commit.I kept the first bullet point because the docs recommend, as a best practice, to use
newtabref
for links navigating away fromdevelopers.mattermost.com
.The
date
ine2e-cheatsheets.md
used a format that wasn't parsable leading to this error when I ranmake run
.It seems the author forgot to add the seconds in the time format leading to an error. I can see from the current date they meant the time to be exactly midnight, so I added some zeroes for the seconds.
The date now uses one of the parsable formats recommended by the Hugo documentation.
Ticket Link
N/A