Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate point and fix date format #1410

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

Victor-Nyagudi
Copy link
Contributor

@Victor-Nyagudi Victor-Nyagudi commented Oct 29, 2024

Summary

Removed a duplicate bullet point on the "Why and how to contribute" page.

I kept the second bullet point because it's the most recent one added in this commit.

I kept the first bullet point because the docs recommend, as a best practice, to use newtabref for links navigating away from developers.mattermost.com.

The date in e2e-cheatsheets.md used a format that wasn't parsable leading to this error when I ran make run.

ERROR the "date" front matter field is not a parsable date: 
see /{Path from my Mac}/mattermost-developer-documentation/site/content/contribute/more-info/webapp/e2e-cheatsheets.md

It seems the author forgot to add the seconds in the time format leading to an error. I can see from the current date they meant the time to be exactly midnight, so I added some zeroes for the seconds.

The date now uses one of the parsable formats recommended by the Hugo documentation.

Ticket Link

N/A

The current date format wasn't parsable leading to an error when running 'make run'. I kept the second bullet point because it's the most recent one.
@mattermost-build
Copy link
Contributor

Hello @Victor-Nyagudi,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

The docs recommend using 'newtabref' for links navigating away from developers.mattermost.com
@Victor-Nyagudi
Copy link
Contributor Author

cc: @cwarnermm

Discussed the change first in the Mattermost Content channel.

@Victor-Nyagudi Victor-Nyagudi marked this pull request as ready for review October 29, 2024 14:07
@cwarnermm cwarnermm self-requested a review October 30, 2024 13:31
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 30, 2024
Copy link

Newest code from Victor-Nyagudi has been published to preview environment for Git SHA 56a0e79

The current date format wasn't parsable leading to an error when running 'make run'. I kept the second bullet point because it's the most recent one.
The docs recommend using 'newtabref' for links navigating away from developers.mattermost.com
@Victor-Nyagudi
Copy link
Contributor Author

Thought I'd fix that sentence in this PR as well.

Discussed it first in this channel.

Didn't know master had already been merged into this PR so I didn't pull the changes first resulting in divergent branches.

I used git config pull rebase false before pulling the changes hence the duplicate commits. Hope that doesn't complicate things too much.

Is a "squash and merge" a viable option here?

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Victor-Nyagudi!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Oct 30, 2024
@cwarnermm cwarnermm requested a review from amyblais October 30, 2024 17:12
@cwarnermm cwarnermm mentioned this pull request Oct 30, 2024
@cwarnermm cwarnermm removed the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 31, 2024
@cwarnermm cwarnermm merged commit 3e3a824 into mattermost:master Oct 31, 2024
5 of 6 checks passed
@Victor-Nyagudi Victor-Nyagudi deleted the remove-duplicate-point branch November 3, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants