-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Focalboard] Upgrade to latest stable version 0.9.2 #270
base: master
Are you sure you want to change the base?
Conversation
Hello @chetancyberoi, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr
please sign the CLA
and check some comments and check the ci failure
also, please describe your change in the PR summary
|
||
service: | ||
type: ClusterIP | ||
type: LoadBalancer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why loadbalancer?
@@ -59,13 +59,13 @@ ingress: | |||
# - chart-example.local | |||
## Persist data to a persitent volume | |||
persistence: | |||
enabled: false | |||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert this changes?
## If defined, volume.beta.kubernetes.io/storage-class: <storageClass> | ||
## Default: volume.alpha.kubernetes.io/storage-class: default | ||
## | ||
# storageClass: | ||
# accessMode: ReadWriteOnce | ||
# size: 8Gi | ||
accessMode: ReadWriteOnce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
@@ -26,19 +26,19 @@ serviceAccount: | |||
|
|||
podAnnotations: {} | |||
|
|||
podSecurityContext: {} | |||
# fsGroup: 2000 | |||
podSecurityContext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @chetancyberoi |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
No description provided.