Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added securityContext on mattermost-operator helm chart deployment #340

Merged
merged 9 commits into from
Oct 4, 2023

Conversation

frjaraur
Copy link
Contributor

@frjaraur frjaraur commented Jun 9, 2022

Summary

Added securityContext on mattermost-operator helm chart deployment

Ticket Link

This just add securityContext on mattermost-operator helm chart deployment as discussed on #339.

frjaraur added 2 commits May 31, 2022 15:48
Added securityContext options for secure environments where Pods execution requires non-root user definition.
Added example working securityContext for mattermost-operator.
@mattermod
Copy link
Contributor

Hello @frjaraur,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@ghost ghost requested review from stylianosrigas, phoinixgrr, spirosoik and a user June 20, 2022 07:21
@phoinixgrr phoinixgrr removed their request for review August 18, 2022 05:58
@spirosoik
Copy link
Member

@frjaraur thanks for your contribution. Could we fix the lint errors and rebase with latest master please?

@frjaraur
Copy link
Contributor Author

Hi @spirosoik, I am reviewing right now, but I am not sure if lint is reporting just the chart release change. I changed Chart release to 0.3.2. Please let me know if this solves the problem (first time contributing to this project).

@spirosoik
Copy link
Member

/update-branch

@spirosoik
Copy link
Member

Hi @spirosoik, I am reviewing right now, but I am not sure if lint is reporting just the chart release change. I changed Chart release to 0.3.2. Please let me know if this solves the problem (first time contributing to this project).

you need to bump the version actually, there was already an update in the repo

Chart release changed to 0.3.3 to include security context changes.
@frjaraur
Copy link
Contributor Author

I reviewed Chart release and upgraded to 0.3.3.

@spirosoik spirosoik removed request for stylianosrigas and a user February 2, 2023 07:45
@spirosoik
Copy link
Member

/update-branch

@stylianosrigas
Copy link
Contributor

@frjaraur Thanks for the contribution and sorry it took some time to review and move forward. Can you please resolve the conflicts to merge the PR?

@frjaraur
Copy link
Contributor Author

frjaraur commented Oct 4, 2023

Done, let me know.

Copy link
Contributor

@stylianosrigas stylianosrigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again 🚀

Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!!!

@spirosoik spirosoik merged commit 9748458 into mattermost:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants