-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added securityContext on mattermost-operator helm chart deployment #340
Conversation
Added securityContext options for secure environments where Pods execution requires non-root user definition.
Added example working securityContext for mattermost-operator.
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@frjaraur thanks for your contribution. Could we fix the lint errors and rebase with latest master please? |
Hi @spirosoik, I am reviewing right now, but I am not sure if lint is reporting just the chart release change. I changed Chart release to 0.3.2. Please let me know if this solves the problem (first time contributing to this project). |
/update-branch |
you need to bump the version actually, there was already an update in the repo |
Chart release changed to 0.3.3 to include security context changes.
I reviewed Chart release and upgraded to 0.3.3. |
/update-branch |
@frjaraur Thanks for the contribution and sorry it took some time to review and move forward. Can you please resolve the conflicts to merge the PR? |
Done, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!!!
Summary
Added securityContext on mattermost-operator helm chart deployment
Ticket Link
This just add securityContext on mattermost-operator helm chart deployment as discussed on #339.