[MM-49202] Add retention time for failed calls-offloader jobs #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
1: Dev Review
stylianosrigas
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
LGTM @streamer45 thank you. Once merged, I will handle the release.
streamer45
added
2: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per related PR, starting in the next version we'll be able to configure a retention time for failed jobs through the
JOBS_FAILEDJOBSRETENTIONTIMEenv variable which controls theTTLSecondsAfterFinishedvalue of the kubernetes job spec. This should finally remove the need to manually delete every failed recording jobs.Related PR
mattermost/calls-offloader#43
Ticket Link
https://mattermost.atlassian.net/browse/MM-49202