Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLD-7443] Allow rtcd service to be exposed on a privileged port #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

[CLD-7443] Allow rtcd service to be exposed on a privileged port #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/mattermost-rtcd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: mattermost-rtcd
description: A Helm chart for Kubernetes to deploy Mattermost's RTCD
type: application
version: 1.4.0
version: 1.5.0
appVersion: latest
keywords:
- mattermost
Expand Down
6 changes: 3 additions & 3 deletions charts/mattermost-rtcd/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
dnsPolicy: ClusterFirstWithHostNet
hostNetwork: true
hostNetwork: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to do this, I would make this a variable that can be controlled from the values file since there are still cases where it would be valuable to use host networking since it simplifies the generation of local candidates.

serviceAccountName: {{ include "mattermost-rtcd.serviceAccountName" . }}
terminationGracePeriodSeconds: {{ .Values.configuration.terminationGracePeriod }}
securityContext:
Expand All @@ -57,11 +57,11 @@ spec:
hostPort: {{ .Values.service.APIport }}
protocol: TCP
- name: rtc-udp
containerPort: {{ .Values.service.RTCport }}
containerPort: {{ .Values.service.RTCTargetPort }}
hostPort: {{ .Values.service.RTCport }}
protocol: UDP
- name: rtc-tcp
containerPort: {{ .Values.service.RTCport }}
containerPort: {{ .Values.service.RTCTargetPort }}
hostPort: {{ .Values.service.RTCport }}
protocol: TCP
livenessProbe:
Expand Down
3 changes: 3 additions & 0 deletions charts/mattermost-rtcd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ configuration:
# RTCD_LOGGER_ENABLEFILE: "\"false\""
# RTCD_RTC_ICEPORTUDP: "\"8443\""
# RTCD_RTC_ICEPORTTCP: "\"8443\""
# RTCD_RTC_ICEHOSTPORTOVERRIDE: "\"443\""

maxUnavailable: 1 # Only used when updateStrategy is set to "RollingUpdate"
updateStrategy: RollingUpdate
Expand All @@ -69,6 +70,8 @@ service:
APIport: 8045
# RTCport is the port (both UDP and TCP) that will serve calls related traffic (i.e. audio,video)
RTCport: 8443
# RTCTargetPort is the port (both UDP and TCP) that the service will be listening on internally (in container).
RTCTargetPort: 8443

ingress:
enabled: false
Expand Down
Loading