Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add "wizard createconfig" command to easily populate configuration files #743

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmartingr
Copy link
Contributor

Summary

In order to make iteration, first usage and potentially development faster I see myself editing, copying and pasting files manually around so it occurred to me that having a command to easily populate the basics for configuration files would be particularily useful.

I envisioned this as a question-answer prompt, but having a command with flags seems more appropriate here and we can always evolve into something like that.

This Pull Request contains the first steps for that, allowing to run a ltctl wizard createconfig command with several flags to populate the config.json and deployment.json files with predefined values for an environment with an specific amount of active concurrent users (determines by the --active-users flag).

I added some draft structures around to define this architecture list borrowing the information from the references architectures work, but we would also need to define number of agents and all other load-test specific configuration.

This is just a first step/draft idea, let me know what you think @agnivade @agarciamontoro

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea! In particular, I like the deployment/infrastructure.go file: I feel there's great potential there to manage templates like you propose, and we can follow the results of the ceiling tests as a first step. Thank you!

I also like the idea of a question-answer prompt, and I think we can directly work on that. Do you want to keep working on this or is there a lot on your plate right now?

Btw, feel free to ask for a review in these PRs even if they're in a WIP state. Otherwise I'll probably forget about them, as it happened with this 🤓 Sorry!

@agnivade
Copy link
Member

agnivade commented Aug 6, 2024

I personally feel more comfortable directly editing config files. But I don't mind this. Feel free to ask a review once it's ready.

@fmartingr
Copy link
Contributor Author

I personally feel more comfortable directly editing config files. But I don't mind this. Feel free to ask a review once it's ready.

My objective with this is having a initial setup to create the config files, and then those should be edited manually. But for example if you want to have a load-test for a 50k envionrment, instead of modifying the files manually you could just execute the CLI command to setup those values in the files with one command, and then proceed to tune other things that you may want to change.

@agnivade
Copy link
Member

agnivade commented Aug 7, 2024

I usually copy the template from *.sample.json and modify them manually. But it's just my personal preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants