Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Charging module fixes #260

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Smart Charging module fixes #260

merged 2 commits into from
Feb 17, 2024

Conversation

matth-x
Copy link
Owner

@matth-x matth-x commented Feb 17, 2024

During tests, three defects were found:

  • Config ChargingScheduleMaxPeriods was ignored when interpreting charging schedules
  • The installed profiles were not counted correctly, allowing to install more profiles than defined by MaxChargingProfilesInstalled
  • The transactionId of the TxProfile wasn't checked against the currently running transaction

Thanks again to the engineer who reported all these defects.

@matth-x matth-x merged commit dc2cdaa into master Feb 17, 2024
5 checks passed
@matth-x matth-x deleted the fix/smart-charging branch February 17, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant