Skip to content

Fix reported defects #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Fix reported defects #271

merged 16 commits into from
Apr 19, 2024

Conversation

matth-x
Copy link
Owner

@matth-x matth-x commented Mar 10, 2024

Fix defects which appeared during an integration test. Summary:

  • Fix crash when locally deauthorizing connectorIds > 1 (see fixed endTansaction method for connectors other than 1 #275)
  • Add config Cst_TxStartOnPowerPathClosed:
    • false (default): Tx start point is when charging is authorized and cable is plugged
    • true: Tx start point is when the vehicle actually started charging
  • Don't initialize FirmwareManagement modules by default. Accept UpdateFirmware and GetDiagnostics only when corresponding handlers are set
  • UnlockConnector reports proper status when connector lock handler is not set
  • SmartCharging module edge cases fixes

@matth-x matth-x marked this pull request as ready for review April 18, 2024 20:02
@matth-x matth-x force-pushed the fix/testing-results branch from 6ea2fcb to eb41d89 Compare April 18, 2024 20:06
@matth-x matth-x merged commit d9d5345 into main Apr 19, 2024
5 checks passed
@matth-x matth-x deleted the fix/testing-results branch April 19, 2024 10:20
matth-x added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants