-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPP 2.0.1 Fixes after functionality tests #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cumulative updates of the OCPP 2.0.1 extension.
In the course of replacing scoped enums with C-style enums,
MicroOcpp::ReadingContext
changes intoReadingContext
and the values change fromMicroOcpp::ReadingContext::SamplePeriodic
(for example) toReadingContext_SamplePeriodic
The build flag to control the number of EVSEs is misleading, because it doesn't define the actual number of EVSEs but the number of EVSE IDs starting from 0. Therefore,
MO_NUM_EVSE
was renamed intoMO_NUM_EVSEID
. For example, ifMO_NUM_EVSEID=2
, then the two IDs 0 and 1 exist, but there is only one actual EVSE with the ID 1.The Request Queue deduplicates StatusNotifications since 1098e95 which is reverted in this PR. The issue is that the unit test suite triggers custom StatusNotifications, which doesn't support the API required by the Requeust Queue.
And this PR contains a number of small general improvements of the OCPP 2.0.1 extension, like MeterValue support and a port of the following API functions:
isTransactionActive()
,isTransactionRunning()
,getTransactionIdTag()
,getChargePointStatus()
,setConnectorPluggedInput()
,setEnergyMeterInput()
,setPowerMeterInput()
,addMeterValueInput()
,setEvseReadyInput()
,setOccupiedInput()
,isOperative()