Be more forgiving

matthiask · Sep 17, 2023 · ca8dcf0 · ca8dcf0
1 parent 4cd626f
commit ca8dcf0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -5,6 +5,11 @@ Change log
 Next version
 ============
 
+- Changed the roles implementation to allow using arbitrary names for the role
+  field.
+- Stopped crashing when encountering an unknown role -- doing nothing in
+  ``has_perm`` is an acceptable fallback.
+
 
 0.16 (2023-09-17)
 =================

diff --git a/authlib/roles.py b/authlib/roles.py
@@ -40,8 +40,8 @@ def contribute_to_class(self, cls, name):
         super().contribute_to_class(cls, name)
 
         def _role_has_perm(self, *, perm, obj):
-            if callback := _roles()[self.role].get("callback"):
-                return self.is_active and callback(user=self, perm=perm, obj=obj)
+            if (r := _roles()[getattr(self, name)]) and (cb := r.get("callback")):
+                return self.is_active and cb(user=self, perm=perm, obj=obj)
 
         cls._role_has_perm = _role_has_perm