Skip to content

Commit

Permalink
remove former round fix and downgrade ps_googleanalytics"
Browse files Browse the repository at this point in the history
  • Loading branch information
Matthieu Rolland committed Mar 1, 2024
1 parent 1355ba1 commit 1fde03f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
5 changes: 0 additions & 5 deletions classes/Tools.php
Original file line number Diff line number Diff line change
Expand Up @@ -1769,11 +1769,6 @@ public static function ps_round($value, $precision = 0, $round_mode = null)
*/
public static function math_round($value, $places, $mode = PS_ROUND_HALF_UP)
{
// since php 8.1 the round function won't tolerate null values
if (empty($value)) {
$value = 0.0;
}

//If PHP_ROUND_HALF_UP exist (PHP 5.3) use it and pass correct mode value (PrestaShop define - 1)
if (defined('PHP_ROUND_HALF_UP')) {
return round($value, $places, $mode - 1);
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"prestashop/ps_facetedsearch": "^3.2.1",
"prestashop/ps_faviconnotificationbo": "^2",
"prestashop/ps_featuredproducts": "^2",
"prestashop/ps_googleanalytics": "^5",
"prestashop/ps_googleanalytics": "^4.1",
"prestashop/ps_imageslider": "^3",
"prestashop/ps_languageselector": "^2",
"prestashop/ps_linklist": "^6",
Expand Down
16 changes: 8 additions & 8 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1fde03f

Please sign in to comment.