-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Secondary actions menu #32
base: master
Are you sure you want to change the base?
Conversation
26d0fcc
to
232ed4a
Compare
@mattydebie Have you had a chance to try this out? It's mostly fleshed out, but there are refactorings I think would be great, but some of the existing functionality will be difficult (though not impossible) to preserve. The biggest behavior that's going to be difficult to preserve is the Alt shortcuts for copying & autotyping. At the moment, they work, but the code for the Alt shortcut duplicates knowledge in the secondary menu generation. I'd like to DRY that up, and I have an idea to do so that might work, but it's going to get pretty ugly because Bash just doesn't have great support for structured data. Personally, I think this secondary menu is better than the Alt shortcuts, but it would be slower for someone with muscle memory for the Alt shortcuts. Can I ditch them, or should I try to preserve them with some wild bashery? |
de3496f
to
b891627
Compare
I always try to use shift+Insert in terminals, so I want the password in the primary selection as well. I realize not everybody wants this, mattydebie#32 for example is proposing a workflow of copying username into one selection, and password into another.
I would often like more options when interacting with the items in my vault. Currently, bwmenu allows you to:
Here are some things I would love to be able to do, but currently cannot:
This pull request is a work-in-progress take on how this could work. With these changes, when you select a vault item with Enter, instead of copying the password, it opens a second menu that provides you with a list of actions for that item, which execute when selected.
The list of actions is dynamic and particular to the selected item. If the item doesn't have a URI, the URI-related actions aren't included. Actions should depend, also, on the type of item (credit card, login item, identity, etc).
I think the additional abilities and control you get with this secondary menu are great. Being able to copy both your username and password at the same time is a huge speed boon as well.
The code is not ready to be merged yet, but I wanted to open the PR now anyway to start the discussion. Is this something you'd be interested in? I don't believe there need to be any real drawbacks.
Here's the current status of the code:
SHOW_PASSWORD
variable