-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category - The "Type" field is missing after saving an unfilled form #14168 #14445
base: 5.2
Are you sure you want to change the base?
Conversation
Please check the failing test @levente999 - thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14445 +/- ##
=========================================
Coverage 63.45% 63.45%
- Complexity 34633 34635 +2
=========================================
Files 2273 2273
Lines 103596 103603 +7
=========================================
+ Hits 65732 65737 +5
- Misses 37864 37866 +2
|
This change shows the field where it shouldn't now as the bundle is known when creating the category for example from the segment edit form, it's obvious that it should be for segments: Screen.Recording.2025-01-09.at.14.35.42.movAnd please, cover the change with functional tests that will make sure it won't get broken in the future. |
@levente999 you also need to fix the problem that @escopecz has mentioned where the field is showing where it shouldn't. Please take a look at that. |
Removing from the milestone due to unresolved feedback and tests being required. |
Description
Fixes #14168
This PR resolves an issue where the Type field disappears from the "New Category" form after clicking the "Save" button without filling out other fields (e.g., Title, Description, Alias, and Color). The fix ensures that the Type field remains visible and persists regardless of form validation failures.
See https://monosnap.com/file/PfAT6BW5tV3ueo8da0QBhfuqtXv3sq
📋 Steps to test this PR:
Step 1: Install Mautic
Step 2: Input valid credentials
Step 3: Click on the "Login" button
Step 4: Click on the Settings icon at the top right of the screen
Step 5: Click on Categories
Step 6: Click on the "New" button
Step 7: Leave the Title, Description, Alias, and Color fields blank
Step 8: Click on the "Save" button
Step 9: Still appeared the "Type" field