Allow disabling automatic key fetching for Olm machine #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifi
force-pushed
the
feature/disable-key-fetching
branch
from
49355bd to
20de54d
Compare
tulir
reviewed
Jan 10, 2024
sumnerevans
reviewed
Jan 10, 2024
hifi
force-pushed
the
feature/disable-key-fetching
branch
4 times, most recently
from
41f9301 to
5ae6b22
Compare
tulir
approved these changes
Jan 12, 2024
Many crypto operations in the Olm machine have a possible side effect of fetching keys from the server if they are missing. This may be undesired in some special cases. To tracking which users need key fetching, CryptoStore now exposes APIs to mark and query the status.
hifi
force-pushed
the
feature/disable-key-fetching
branch
from
5ae6b22 to
d51f32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many crypto operations in the Olm machine have a possible side effect of fetching keys from the server if they are missing. This may be undesired in some special cases.
To tracking which users need key fetching, CryptoStore now exposes APIs to mark and query the status.