CMake: Make qmlglsink Private

mavlink · Apr 19, 2024 · 64e1d5d · 64e1d5d
1 parent 1579b15
commit 64e1d5d
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 22 deletions.
diff --git a/libs/qmlglsink/CMakeLists.txt b/libs/qmlglsink/CMakeLists.txt
@@ -208,9 +208,6 @@ if(QGC_ENABLE_VIDEOSTREAMING)
 	        PRIVATE
 	            HAVE_QT_QPA_HEADER
 	            QT_QPA_HEADER=<QtGui/qpa/qplatformnativeinterface.h>
-	        PUBLIC
-	            QGC_GST_STREAMING
-	            QGC_CMAKE_GST
 	    )
 	    if(LINUX)
 	    	target_compile_definitions(qmlglsink PRIVATE HAVE_QT_X11)

diff --git a/src/VideoReceiver/CMakeLists.txt b/src/VideoReceiver/CMakeLists.txt
@@ -1,20 +1,19 @@
-find_package(Qt6 REQUIRED COMPONENTS Core Multimedia)
+find_package(Qt6 REQUIRED COMPONENTS Core)
 
 qt_add_library(VideoReceiver STATIC
     VideoReceiver.h
 )
 
 target_link_libraries(VideoReceiver
     PUBLIC
-        Qt6::Multimedia
-        Qt6::OpenGL
-        Qt6::Quick
-        Utilities
+        Qt6::Core
 )
 
 target_include_directories(VideoReceiver PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 
 if(GST_FOUND)
+    find_package(Qt6 REQUIRED COMPONENTS Quick)
+
     target_sources(VideoReceiver
         PRIVATE
             gstqgc.c
@@ -26,11 +25,16 @@ if(GST_FOUND)
     )
 
     target_link_libraries(VideoReceiver
-        PUBLIC
+        PRIVATE
             qmlglsink
+            Utilities
+        PUBLIC
+            Qt6::Quick
             Settings
     )
 
+    target_compile_definitions(VideoReceiver PUBLIC QGC_GST_STREAMING)
+
     if(CMAKE_BUILD_TYPE STREQUAL "Release")
         target_compile_definitions(VideoReceiver PRIVATE QGC_INSTALL_RELEASE)
     endif()

diff --git a/src/VideoReceiver/GStreamer.cc b/src/VideoReceiver/GStreamer.cc
@@ -14,7 +14,7 @@
  *   @author Gus Grubba <[email protected]>
  */
 
-#include <QDebug>
+#include <QtCore/QDebug>
 
 #include "GStreamer.h"
 #include "GstVideoReceiver.h"

diff --git a/src/VideoReceiver/GStreamer.h b/src/VideoReceiver/GStreamer.h
@@ -1,14 +1,15 @@
 #pragma once
 
 #include <QtCore/QLoggingCategory>
-#include <QQuickItem>
+#include <QtQuick/QQuickItem>
 
 #include "Settings/VideoDecoderOptions.h"
-#include "VideoReceiver.h"
 
 Q_DECLARE_LOGGING_CATEGORY(GStreamerLog)
 Q_DECLARE_LOGGING_CATEGORY(GStreamerAPILog)
 
+class VideoReceiver;
+
 class GStreamer {
 public:
     static void blacklist(VideoDecoderOptions option);

diff --git a/src/VideoReceiver/GstVideoReceiver.cc b/src/VideoReceiver/GstVideoReceiver.cc
@@ -17,9 +17,9 @@
 #include "GstVideoReceiver.h"
 #include "QGCLoggingCategory.h"
 
-#include <QDebug>
-#include <QUrl>
-#include <QDateTime>
+#include <QtCore/QDebug>
+#include <QtCore/QUrl>
+#include <QtCore/QDateTime>
 
 QGC_LOGGING_CATEGORY(VideoReceiverLog, "VideoReceiverLog")
 

diff --git a/src/VideoReceiver/GstVideoReceiver.h b/src/VideoReceiver/GstVideoReceiver.h
@@ -16,11 +16,11 @@
 #pragma once
 
 #include <QtCore/QLoggingCategory>
-#include <QTimer>
-#include <QThread>
-#include <QWaitCondition>
-#include <QMutex>
-#include <QQueue>
+#include <QtCore/QTimer>
+#include <QtCore/QThread>
+#include <QtCore/QWaitCondition>
+#include <QtCore/QMutex>
+#include <QtCore/QQueue>
 
 #include "VideoReceiver.h"
 

diff --git a/src/VideoReceiver/VideoReceiver.h b/src/VideoReceiver/VideoReceiver.h
@@ -15,8 +15,8 @@
 
 #pragma once
 
-#include <QObject>
-#include <QSize>
+#include <QtCore/QObject>
+#include <QtCore/QSize>
 
 class VideoReceiver : public QObject
 {