-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick controls2 basic missing libraries added #11273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok. Any objections @HTRamsey?
@julianoes can you rerun the failed linux builds? We can ignore the android failure |
So interestingly this issue started at commit a95dfd1, which changed nothing about the code. However it is where Android Builds started failing. But #11274 doesn't fix the issue, and it doesn't work on my private repo either so it's not related to Qt download caches. It would make sense that this library is required but I don't get why it's randomly needed now and not before. It worked perfectly fine after #11256. My best guess is that this is somehow related to the Qt download source, and something changed there that affected everything else. |
@HTRamsey I can squash and rebase both commits (would do anyways later so it goes clean into master), so it can rerun the tests. |
libQt6QuickControls2Basic.so.6 added libQt6QuickControls2BasicStyleImpl.so.6 added
d7eb4d2
to
f473f36
Compare
My guess is that somewhere someone might be using a raw Qml control instead of the QGC styled ones. These seem to be control style files. That said I don't see how it hurts (other than file size) to include these. Hopefully once we move to cmake all this goes away anyway. |
This breaks the Linux build for me. For some reasons I don't have these libraries in my Qt 6.6.1 (or 6.6.2).
This is how I build on Ubuntu 22.04/Linux Mint:
|
@julianoes do you have any of these? |
Was I meant to install something else? |
Hey. Have you found any ways to solve the broken local build? It fails for me in the exact same way, both on Ubuntu 22.04 with Qt 6.6.1 (I tried installing it both from |
@HTRamsey Any ideas what to do here? |
I can look into it more, but at least the issue is just a qmake thing for now. I don't understand why they don't get the QQuickStyles installed |
Oh, didn't realize it was qmake only. |
Hello guys, any updates on this? I'm getting the same error here. I'm using Ubuntu 22.04.4 LTS. I have installed Qt 6.6.1 via Qt online installer and I'm trying to build using container Building using Containers. I've just cloned the repository so I have the latest commit. I never get those Qt libs installed:
Here are the libs that were installed:
After running the
|
Use Qt 6.6.3 |
This helped. I changed (locally) |
Quick controls2 basic missing libraries added
Description
Some missing libraries for AppImage were added to
QGCPostLinkCommon.pri
to load the Quick Controls2 Basic resourcesTest Steps
Checklist:
Related Issue
More details about the problem can be found in #11272
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.