Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix Docs Deploy #11348

Merged
merged 1 commit into from
Apr 18, 2024
Merged

CI: Fix Docs Deploy #11348

merged 1 commit into from
Apr 18, 2024

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Apr 17, 2024

I guess the output from the build step wasn't working like I had expected.
I think it might be worthwhile to let it upload the build artifact to review locally, so i removed the requirement for that part, but left the check for deployment.

@hamishwillee
Copy link
Contributor

Perhaps one for @DonLakeFlyer to review. This looks OK to me, but since this isn't in /docs path the workflow itself is untested.

Note, we should also update the other workflows to make sure that they ignore changes in the /docs path.

@DonLakeFlyer
Copy link
Contributor

So this basically goes back to the way it was before right? I'm not super familiar with the docs workflow.

@HTRamsey
Copy link
Collaborator Author

HTRamsey commented Apr 18, 2024

It still has the node version change, and uploads the build result artifact, but otherwise yes. We will have to manually run the docs workflow to double check though.

@DonLakeFlyer DonLakeFlyer merged commit 94f779e into mavlink:master Apr 18, 2024
8 checks passed
@HTRamsey HTRamsey deleted the dev-docs branch April 18, 2024 19:51
@hamishwillee
Copy link
Contributor

Note, we should also update the other workflows to make sure that they ignore changes in the /docs path.

NOte that again ^^^ - every time I make a docs change it forces a rebuild on everything. That doesn't need to happen.

@HTRamsey
Copy link
Collaborator Author

They should all have

paths-ignore:
      - 'docs/**'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants