WIP - OSX cmake dmg #11364
WIP - OSX cmake dmg #11364
Conversation
| if(MACOS) | ||
| find_library(GSTREAMER_FRAMEWORK | ||
| NAMES GStreamer | ||
| HINTS ${GSTREAMER_ROOT}) |
There was a problem hiding this comment.
Because we are using a Framework for gstreamer you use find_library to find it. cmake supports finding frameworks in find_library.
| if (GSTREAMER_FRAMEWORK-NOTFOUND) | ||
| message(WARNING "Gstreamer Framework Not Found") | ||
| else() | ||
| set(GST_FOUND TRUE) |
There was a problem hiding this comment.
Since the find_library uses a different mechanism to find the framework the GST_FOUND variable is not set automatically. So I set it manually here. I must be doing this wrong somehow.
There was a problem hiding this comment.
In this specific CMakelists.txt it does see that GST_FOUND was set to TRUE further down the file.
| @@ -35,6 +35,7 @@ if(GST_FOUND) | |||
| Settings | |||
| ) | |||
|
|
|||
| message(FATAL_ERROR "GST_FOUND: ${GST_FOUND}") | |||
There was a problem hiding this comment.
But once it gets here it doesn't see that GST_FOUND is set to TRUE.
| @@ -32,6 +32,7 @@ | |||
| #include "GStreamer.h" | |||
| #include "VideoSettings.h" | |||
| #else | |||
| #error Boom | |||
There was a problem hiding this comment.
And then I use this to verify that the DEFINE is set correctly which it is not.
|
@HTRamsey I added comments to the changes to show what I'm running into. Probably something simple related to my cmake stupidity. |
So this is what I have been testing with.