AnalyzeView: Fix GeoTagWorker Threading #11813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
2 times, most recently
from
e351524 to
056dbac
Compare
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
6 times, most recently
from
e8955cc to
c4e309f
Compare
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
from
c4e309f to
8ba6129
Compare
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
3 times, most recently
from
9fc1b70 to
ea6d6db
Compare
DonLakeFlyer
approved these changes
Oct 10, 2024
|
|
||
| _worker->moveToThread(_workerThread); | ||
|
|
||
| (void) connect(_worker, &GeoTagWorker::progressChanged, this, &GeoTagController::_workerProgressChanged); |
There was a problem hiding this comment.
Is there something new going on with connect which required the (void) now?
There was a problem hiding this comment.
It's just a pattern carried over from my embedded work. I like to denote that I am intentionally ignoring return values rather than being unaware if it has one or not, helps with collaborating so others know that too
|
@bkueng do you have any sample logs/pics I can use for the unit test? |
|
Not at hand. But if you have a PX4 SITL setup, there's a gazebo classic plugin here: https://github.com/PX4/PX4-SITL_gazebo-classic/blob/main/src/gazebo_camera_manager_plugin.cpp. It's used by the cam_plane model. I never used it myself though. |
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
from
ea6d6db to
5fd7bcf
Compare
HTRamsey
force-pushed
the
dev-analyzeview-geotagworker
branch
from
5fd7bcf to
22d007a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove QThread inheritance and fix QObject parenting
Fixes #11858
Closes #8488 by using timestamps
Also fixes a couple potential logic issues in corner cases
Pending a fix in ExifParser from #11906 first
I still need one really good log source for testing