Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing loiter circles #12033

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix disappearing loiter circles #12033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/PlanView/SimpleItemMapVisual.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,11 @@ Item {
target: _missionItem.isSimpleItem ? _missionItem : null

onLoiterRadiusChanged: {
_loiterVisual.blockSignals = true
_loiterVisual.clockwiseRotation = _missionItem.loiterRadius>= 0
_loiterVisual.blockSignals = false
_loiterVisual.radius.rawValue = Math.abs(_missionItem.loiterRadius)
_loiterVisual.handleLoiterRadiusChange()
}

onCoordinateChanged: {
_loiterVisual.coordinate = _missionItem.coordinate
_loiterVisual.handleCoordinateChange()
}
}

Expand Down Expand Up @@ -147,6 +144,17 @@ Item {
property alias radius: _mapCircle.radius
property alias clockwiseRotation: _mapCircle.clockwiseRotation

function handleLoiterRadiusChange() {
blockSignals = true
clockwiseRotation = _missionItem.loiterRadius>= 0
blockSignals = false
radius.rawValue = Math.abs(_missionItem.loiterRadius)
}

function handleCoordinateChange() {
coordinate = _missionItem.coordinate
}

onCoordinateChanged: _mapCircle.center = coordinate

sourceItem: QGCMapCircleVisuals {
Expand Down Expand Up @@ -177,6 +185,11 @@ Item {
}
}
}

Component.onCompleted: {
handleLoiterRadiusChange()
handleCoordinateChange()
}
}
}
}
Loading