VideoManager: Convert to Singleton #12104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-videomanager
branch
3 times, most recently
from
6ac5972 to
57b7e92
Compare
HTRamsey
force-pushed
the
dev-videomanager
branch
3 times, most recently
from
8a410cf to
6733a15
Compare
HTRamsey
force-pushed
the
dev-videomanager
branch
from
6733a15 to
8c82444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Singleton and perform updates to further support multiple streams by using the VideoReceiverData struct in more places. Tested using RTSP & UVC on Linux & Android.
Later work includes moving the remaining variables like _decoding & _videoSize into the VideoReceiverData so that they can be unique per stream.