Fix crash on startup for older Android devices #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overload to the registerReceiver method with a flags parameter was introduced in API level 26 (Android 8.0), which leads to an instant crash on startup on devices running older versions of Android. Adjusted the implementation to use the previous signature of registerReceiver on devices with API levels below 26.
rubenp02
force-pushed
the
hotfix/fix-android-7-startup-crash
branch
from
0490ccf to
2ed2acd
Compare
|
@rubenp02 just so you know, when we switch to Qt6.8, the minimum supported android will be 9.0. https://doc.qt.io/qt-6.8/whatsnew68.html |
|
I wasn't aware, thank you! That's too bad, many Android-based GCS are on Android 7 (like the SkyDroid H16, which is very widely used in China). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash on startup for older Android devices
Description
The overload to the registerReceiver method with a flags parameter was introduced in API level 26 (Android 8.0), which leads to an instant crash on startup on devices running older versions of Android. Adjusted the implementation to use the previous signature of registerReceiver on devices with API levels below 26.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.