Make handler flush on reset #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handler implements `ResettableInterface`, but does nothing on resetting. That results in logs not getting flushed on long running processes like the message handler. With this flushing should happen on reset.
|
Hi DrLuke, may I know how does the reset() being triggered ? I wrote a scheduler script to reset the log every 5 minutes but it seems like its not working. I realized that it is a different set of buffer depending on where the Log::info() is being triggered. |
|
This affects compatability with Laravel Octane too. Octane has a class Laravel\Octane\Listeners\FlushMonologState, which calls the reset() method. The change in this PR is the same solution we came up with when running into the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
CloudWatchimplementsResettableInterface(viaAbstractHandler), but does nothing on resetting. That means that long running processes like the message consumer don't flush logs between handling messages.What is the current behavior? (You can also link to an open issue here)
Calling
reset()on logger doesn't do anythingWhat is the new behavior (if this is a feature change)?
Calling
reset()on logger flushes messagesDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: