Raise error on HTTP status code 500.

maxdemarzi · Nov 9, 2012 · 267bb32 · 267bb32
1 parent 173a9a4
commit 267bb32
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/lib/neography/connection.rb b/lib/neography/connection.rb
@@ -98,13 +98,13 @@ def evaluate_response(response)
       when 204
         @logger.debug "OK, no content returned" if @log_enabled
         nil
-      when 400...500
-        handle_4xx_response(code, body)
+      when 400..500
+        handle_4xx_500_response(code, body)
         nil
       end
     end
 
-    def handle_4xx_response(code, body)
+    def handle_4xx_500_response(code, body)
       parsed_body = JSON.parse(body)
       message = parsed_body["message"]
       stacktrace = parsed_body["stacktrace"]

diff --git a/spec/unit/connection_spec.rb b/spec/unit/connection_spec.rb
@@ -196,8 +196,15 @@ module Neography
           }.to raise_error NeographyError
         end
 
-      end
+        it "raises BadInputException" do
+          response = error_response(code: 500, message: "a message", exception: "JsonParseException")
+          HTTParty.stub(:get).and_return(response)
+          expect {
+            connection.get("/foo/bar")
+          }.to raise_error NeographyError
+        end
 
+      end
     end
   end
 end