Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(article): only update links for relative images #11

Merged
merged 1 commit into from
Aug 26, 2019
Merged

fix(article): only update links for relative images #11

merged 1 commit into from
Aug 26, 2019

Conversation

BBlackwo
Copy link
Contributor

@BBlackwo BBlackwo commented Aug 2, 2019

I can't get the tests running locally but I hope this should work.

Should close #10

@maxime1992
Copy link
Owner

Thanks for the contribution and the fix @BBlackwo!

I forgot about the tests... I got them to run locally by manually changing the ES6 imports...
I do not know how to currently make it work for both the compilation of the lib and the tests.

I've raised an issue on the typescript library starter I've used here alexjoverm/typescript-library-starter#307

If I get an answer soon I'll fix the tests and you'll be able to rebase, otherwise I'll try to run your branch locally but I hope the tests can be fixed and restored on CI 😓

So putting that one on hold for a bit, if taking too long I'll check and merge 👍

@maxime1992
Copy link
Owner

Hi @BBlackwo sorry I tried to restored the tests but couldn't manage to make them run correctly yet :(

As your PR is pretty simple I think it should be fine to merge and will proceed 🤞

Thanks for your contribution! 👏

@maxime1992 maxime1992 merged commit 0eb6607 into maxime1992:master Aug 26, 2019
@maxime1992
Copy link
Owner

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BBlackwo BBlackwo deleted the dev-bblackwo-only-update-relative-images branch August 26, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag to disable the image translation
2 participants