fix(occara): pass correct c++ std version for the include_cpp macro #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows gh actions runner is currently broken. Will retry later. |
maximmaxim345
force-pushed
the
fix/incorrect-cpp-version-win
branch
2 times, most recently
from
c110364
to
0e30c7f
Compare
|
Using autocxx on Windows with clang 17 currently freezes compilation or fails. Installing clang 16 is not supported by the MSVC version used by the windows-latest gh action runner. Windows support will ignored for now. |
While the code was compiled with the correct c++ version, the 'autocxx::include_cpp' macro still ran with c++14. This fixes building on windows.
maximmaxim345
force-pushed
the
fix/incorrect-cpp-version-win
branch
from
0e30c7f
to
7fd07dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the bindings were compiled with the correct c++ version, the 'autocxx::include_cpp' macro still ran with c++14.