This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Adding Brazilian cards and improve example project #7
Open
ghashi
wants to merge
8
commits into
maxkramer:master
Choose a base branch
from
ghashi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghashi
commented
Apr 29, 2017
- Added Elo, Hipercard and Aura (almost all code is from Eduardo Bocato, I just made it compatible with swift3)
- Improve Example project to show Card Type on the demo
Updating with Brazilian Cards
* Improve Example by including some test data and including the card type on the .xib
ghashi
commented
Apr 29, 2017
let eloo = "636297000045701" | ||
|
||
// src: http://www.geradorcartaodecredito.com.br/hipercard | ||
let hipercard = "6062825756950756" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've added here some testing data in order to helpe testers
typeLabel.text = type.stringValue() | ||
} else { | ||
typeLabel.text = "Unknown" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Now, a type label is included on the demo
Hi @ghashi sorry for the delay on this, I really appreciate your help! If you could update this to be compatible with the latest changes, will happily merge thereafter! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.