Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a client to interact with Bitwarden servers directly #158

Merged
merged 9 commits into from
Sep 29, 2024

Conversation

maxlaverse
Copy link
Owner

@maxlaverse maxlaverse commented Sep 29, 2024

Add a Bitwarden client as part of the project (see #26)

It's still experimental, but would offer the similar trade-off:

  • [+] The provider would work out-of-the-box, without the need of installing the additional binary, making it's much easier to use.
  • [+] The golang implement is much faster than the official client, because there is no need to spawn a NodeJS process on every command.
  • [+] It gives more flexibility, opening up the possibility of creating attachment without having to write them on disk ([FEATURE] Content support for attachments  #146), or user management (FR: User management #134)
  • [-] The provider becomes dependent to the server's implementation, which potentially means more work to support all existing flavors and versions.
  • [-] The encryption is performed by the implementation which come with additional responsibility (e.g. not forgetting to encrypt any attribute with sensitive information) (more tests required)
  • [-] The provider has to stay aligned with the official CLI and applications, in order for items encrypted by one tool to be decryptable by another tool. This means, encrypting the same fields for example.

The idea would be to release the feature as experimental first, until the test coverage is extended and people got the opportunity to report problems and concerns.

@maxlaverse maxlaverse force-pushed the embedded_client branch 2 times, most recently from 3cf8563 to 4605e75 Compare September 29, 2024 18:17
@maxlaverse maxlaverse merged commit fae5d00 into main Sep 29, 2024
1 check passed
@maxlaverse maxlaverse deleted the embedded_client branch September 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant