Skip to content

Commit

Permalink
Remove <application> from AndroidManifest
Browse files Browse the repository at this point in the history
`<application>` in description makes harder to customize it for application. I.e. we are using [react-native-config](https://github.com/luggit/react-native-config) to store all values in one `.env` file and we customize application name with ENV-variable called `DISPLAY_NAME`. For this we use next code in AndroidManifest.yml:

```
<application
      android:name=".MainApplication"
      android:label="@string/DISPLAY_NAME"
      ...
```

In this case there is a conflict with AndroidManifest.yml from react-native-spinkit package, because `android:label` is different in main manifest and local package manifest.

Would be better to remove this tag from AndroidManifest.yml in your package and add wiki instruction to add `android:supportsRtl="true"` in main AndroidManifest.yml.
  • Loading branch information
KELiON authored Jul 31, 2018
1 parent 5c08bdb commit 16bfef2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.react.rnspinkit">

<application
android:label="@string/app_name"
android:supportsRtl="true">

</application>

</manifest>

0 comments on commit 16bfef2

Please sign in to comment.