ios compatibility for RN version < 0.40 #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix when `isVisible` is set to `false` - React was giving an error that View couldn't be found.
Add 'View'
- Code updated to ES6
- android keyword added
Added support for colours with alpha values.
Added missing getters to fix an EXC_BAD_ACCESS crash in RN 0.23.0
Add android support for Wave
…rnally - To be compatible with a variety of color strings (as most other React Native components do in their style's color parameter), we need to call the built-in processColor function provided by React Native. We can then pass the resulting color number to Android Color directly, and can use RCTConvert on iOS to convert it to a valid #AARRGGBB string for UIColor. - Also add .gitignore from recent React Native project version.
Fix propTypes error on Android w/ rn >= 0.45
[tvOS] Add target
Removing allowBackup from AndroidManifest
Add Podspec
Transform any color strings with processColor, use color numbers internally
Remove createJSModules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix #46 #93
Not sure why
react-native-spinkitwill lead to an install of React 0.11 in Pod, that's the root cause of those errors mentioned in two issues.But anyway,
__has_includeis enough to fix it