Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return_null option for partition #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

soyking
Copy link
Contributor

@soyking soyking commented Sep 21, 2017

As described in #26 #43, use RETURN NULL could accelerate the insert action. So here I add the return_null option when use architect.install. It will create the before-insert-trigger without return value and won't create the after-insert-trigger in PostgreSQL.

But there are many limitations:

  • it only works on PostgreSQL
  • for orms like django pony(psycopg2) sqlalchemy(psycopg2) and sqlobject(psycopg2), user should maintain the model's primary id as I did in tests. In some situations, such as using uuid as the primary key.
  • peewee of current version would always fetch the primary key, so it seems not possible to use it as the author said in this issue

It's ok if the MR won't be merged since there are too many limitations which should be declare cleary in documents. Actually I want to know if it could pass the tests in travis :)

@soyking
Copy link
Contributor Author

soyking commented Sep 21, 2017

hmm… werid error, seems irrelevant with the changes

@maxtepkeev
Copy link
Owner

I restarted the job and tests are passing now. You're right, there're some limitations which I need to think about before considering whether to merge this or not. Anyway great work, really appreciate it. Let's keep this PR open for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants