Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo config plugin for AEP RN SDKs #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

mayank-shekhar
Copy link
Owner

No description provided.

The config plugin allows you to set the following options:

- `environmentFileId`: The environment file ID from the Adobe Experience Platform Mobile Tag property value.
- `logLevel`: The log level for the plugin. The available options are `VERBOSE`, `DEBUG`, `INFO`, `WARNING`, and `ERROR`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have Verbose, Debug, Warning and Error.

logLevelCode = ` MobileCore.setLogLevel(.error)`
} else if (logLevel == "WARNING") {
logLevelCode = ` MobileCore.setLogLevel(.warning)`
} else if (logLevel == "VERBOSE" || logLevel == "INFO") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we not just keep Verbose? We don't need to have the option for "INFO"

MobileCore.lifecycleStart(additionalContextData: ["contextDataKey": "contextDataVal"])
}
})
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For iOS, we need to add
func applicationWillEnterForeground(_ application: UIApplication) {
MobileCore.lifecycleStart(additionalContextData: nil)
}

func applicationDidEnterBackground(_ application: UIApplication) {
MobileCore.lifecyclePause()
}

For complete Lifecycle implementation for iOS
https://developer.adobe.com/client-sdks/home/base/mobile-core/lifecycle/#register-lifecycle-with-mobile-core-and-add-appropriate-startpause-calls

We are assuming the app is not a scene-based application, since it will be in different delegate files.

s.dependency "AEPEdge", ">= 5.0.0", "< 6.0.0"
s.dependency "AEPMessaging", ">= 5.0.0", "< 6.0.0"
s.dependency "AEPEdgeIdentity", ">= 5.0.0", "< 6.0.0"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include all the extension here?
EdgeBridge, EdgeConsent, Optimize...

MobileCore.setLogLevel(.error)
}

// Register the extensions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about other extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants