Map to Excel Sheet #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 17, 2024 17:38
millij
reviewed
Dec 17, 2024
| * @param headers a {@link List} of Header names to write in the file. <code>null</code> or empty | ||
| * list will default to all writable properties. | ||
| */ | ||
| void addSheet(List<Map<String, String>> rowsData, String sheetName, List<String> headers); |
There was a problem hiding this comment.
to be consistent, reorder the args
void addSheet(String sheetName, List<String> headers, List<Map<String, String>> rowsData);
millij
reviewed
Dec 17, 2024
| // Data Rows | ||
| for (int i = 0, rowNum = 1; i < rowsData.size(); i++, rowNum++) { | ||
| final Row row = sheet.createRow(rowNum); | ||
| final Map<String, String> rowData = rowsData.get(i); |
There was a problem hiding this comment.
recommend below to hedge against null values
final Map<String, String> rowData = rowsData.getOrDefault(i, new HashMap<>());
millij
reviewed
Dec 17, 2024
|
|
||
| // Header | ||
| final Row headerRow = sheet.createRow(0); | ||
| for (int i = 0; i < inHeaders.size(); i++) { |
There was a problem hiding this comment.
use cellNo instead of i for consistency ?
millij
reviewed
Dec 17, 2024
|
|
||
|
|
||
| @Override | ||
| public void createTemplate(final String sheetName, final List<String> headers) { |
There was a problem hiding this comment.
Method name is ambiguous (based on the implementation)
Also, why not just use addRow method with empty list of rows data?
added 3 commits
December 18, 2024 10:06
… case for addSheet with rows data as List of Map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference
millij#66
PR Contents