-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass at Plaid EU #1555
Initial pass at Plaid EU #1555
Conversation
@zachgoll First high-level pass at adding EU support. You've got a better handle of how the Plaid stuff works, so let me know if I'm off base here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached out to Plaid and they said there is no way to figure out whether an "Item" is US or EU just based on the Plaid Item data.
So the biggest thing we're missing currently here is that identifying piece of data stored on PlaidItem
. I think since there are only 2 possible clients, we could consider a field called plaid_region
that is a string
and in our model we could probably validate that too:
class PlaidItem < ApplicationRecord
enum :plaid_region, { us: "us", eu: "eu" }
end
Which would then allow us to easily access it like, some_item.eu?
Otherwise, I think EU should work largely the same as US and I believe our existing implementation will properly handle these multi-currency accounts fine.
Signed-off-by: Josh Pigford <[email protected]>
@zachgoll Take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I like this strategy of passing it from the Stimulus controller. Should work nicely!
@zachgoll Two things I'm not sure on...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shpigford to my understanding, you have the CA
configuration correct here. I believe CA
is fully covered under the "US" client:
@zachgoll ✅ Anything else before merging this? |
@Shpigford I think we're all set. Only thing I can think of is making sure these are set in prod: PLAID_EU_CLIENT_ID= |
Not to hijack, but would GoCardless be an idea also? That is easily obtainable for self-hosting. |
|
No description provided.