New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle period conflicts #1940

Closed

nikhilbadyal wants to merge 1 commit into maybe-finance:main from nikhilbadyal:nikhil/period-conflict

Contributor

nikhilbadyal commented Mar 2, 2025

Fixes #1939


          Handle period conflicts

c1ce5f4

Collaborator

zachgoll commented Mar 3, 2025

@nikhilbadyal I'm going to close this out as I've implemented a fix in #1944 that addresses the root cause of this at the Period class level.

#1944 will also make #1941 a bit simpler for you as we're now explicitly passing in period keys rather than using the ambiguous fallback: true

zachgoll closed this

nikhilbadyal deleted the nikhil/period-conflict branch

March 3, 2025 18:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet