🔥 Remove oidc_exempt_urls from config models

this field was never actually used, and it does not make sense to make settings that refer to Django stuff (URL patterns in this case) manually configurable instead of programmatically. It caused issues in Open Forms (#4435) where it required manual action from admins if it was kept as a model field.
maykinmedia · Jul 2, 2024 · f27469c · f27469c
1 parent 874ab6a
commit f27469c
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/digid_eherkenning/oidc/admin.py b/digid_eherkenning/oidc/admin.py
@@ -54,7 +54,6 @@
             "oidc_use_nonce",
             "oidc_nonce_size",
             "oidc_state_size",
-            "oidc_exempt_urls",
             "userinfo_claims_source",
         ),
         "classes": ["collapse in"],

diff --git a/digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py b/digid_eherkenning/oidc/migrations/0009_remove_digidconfig_oidc_exempt_urls_and_more.py
@@ -0,0 +1,32 @@
+# Generated by Django 4.2.11 on 2024-07-01 15:15
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        (
+            "digid_eherkenning_oidc_generics",
+            "0008_digidconfig_loa_value_mapping_and_more",
+        ),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="digidconfig",
+            name="oidc_exempt_urls",
+        ),
+        migrations.RemoveField(
+            model_name="digidmachtigenconfig",
+            name="oidc_exempt_urls",
+        ),
+        migrations.RemoveField(
+            model_name="eherkenningbewindvoeringconfig",
+            name="oidc_exempt_urls",
+        ),
+        migrations.RemoveField(
+            model_name="eherkenningconfig",
+            name="oidc_exempt_urls",
+        ),
+    ]