Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bsn validation to mock login form #47

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Oct 23, 2023

Added validation to mock login form that checks length and checksum of BSN

@pi-sigma pi-sigma force-pushed the feature/mock-validate-bsn branch from 10ec658 to 8c56182 Compare October 23, 2023 08:05
@pi-sigma pi-sigma force-pushed the feature/mock-validate-bsn branch from 8c56182 to eda423f Compare October 23, 2023 08:20
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #47 (eda423f) into master (e919dd6) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   96.20%   95.80%   -0.41%     
==========================================
  Files          66       67       +1     
  Lines        3032     3048      +16     
==========================================
+ Hits         2917     2920       +3     
- Misses        115      128      +13     
Files Coverage Δ
digid_eherkenning/mock/idp/forms.py 100.00% <100.00%> (ø)
digid_eherkenning/validators.py 100.00% <100.00%> (ø)
tests/test_mock_forms.py 100.00% <100.00%> (ø)
tests/test_mock_views.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergei-maertens sergei-maertens merged commit 6dcf967 into master Oct 23, 2023
13 of 14 checks passed
@sergei-maertens sergei-maertens deleted the feature/mock-validate-bsn branch October 23, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants