👽 Replace deprecated defusedxml.lxml module usage #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
chore/replace-deprecated-defusedxml-lxml-module-usage
branch
from
3ed4a9b to
5de1385
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 71 72 +1
Lines 3212 3215 +3
=======================================
+ Hits 3084 3087 +3
Misses 128 128 ☔ View full report in Codecov by Sentry. |
|
@CharString I've picked you for review since I'm not 100% certain yet that this doesn't open up any security holes 🤔 |
sergei-maertens
force-pushed
the
chore/replace-deprecated-defusedxml-lxml-module-usage
branch
from
5de1385 to
d61c56a
Compare
In 2024 this is no longer essential, using lxml by itself should be sufficient. See also the discussion on python.org: https://discuss.python.org/t/status-of-defusedxml-and-recommendation-in-docs/34762/3
sergei-maertens
force-pushed
the
chore/replace-deprecated-defusedxml-lxml-module-usage
branch
from
cd01bb3 to
dbc8fba
Compare
CharString
requested changes
Feb 15, 2024
This repeats the lower bound from maykin-python3-saml but makes it explicit.
This should mostly be a no-op except that it effectively purges defusedxml.lxml usage.
CharString
approved these changes
Feb 15, 2024
sergei-maertens
deleted the
chore/replace-deprecated-defusedxml-lxml-module-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-formulieren/open-forms#1052