Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eIDAS LoA configurable #64

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

SilviaAmAm
Copy link
Contributor

I was going crazy navigating all the different config dicts, so I added some types. They need further development, but they are better than nothing (I think).
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (0985701) to head (79825e8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   96.10%   96.21%   +0.10%     
==========================================
  Files          73       75       +2     
  Lines        3260     3353      +93     
==========================================
+ Hits         3133     3226      +93     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review March 15, 2024 11:41
@SilviaAmAm SilviaAmAm requested review from vaszig and Viicos March 18, 2024 08:57
Copy link
Contributor

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice type improvements 👍

@SilviaAmAm SilviaAmAm merged commit 57931d4 into master Mar 21, 2024
14 checks passed
@SilviaAmAm SilviaAmAm deleted the feature/make-eidas-configurable branch March 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple LoAs to eHerkenning and eIDAS and update the service catalog template
3 participants